Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Layton [jlayton@xxxxxxxxxx] wrote:
> 1) should we retry these calls on all filesystems, or attempt to have
> them "opt-in" in some fashion? This patch adds a flag for that, but
> we could just treat all filesystems the same way.

I don't know any cases where a retry on ESTALE would hurt. I would say
retry on all file systems the same way.

> 2) How many times should we retry on an ESTALE error? Once?
> Indefinitely? Some amount in between? Retrying once would probably
> fix the bulk of the real world problems with this, but there will
> still be cases where that's not sufficient.

As you say 1 retry should work in most cases. Indefinitely doesn't make
sense, I would rather let my application fail! How about 3 retries (3 is
a nice number! :-) )

Regards, Malahal.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux