On Mon, 2012-03-05 at 19:53 -0500, Steve Dickson wrote:
>
> On 03/05/2012 07:31 PM, Myklebust, Trond wrote:
> > On Mon, 2012-03-05 at 19:27 -0500, Steve Dickson wrote:
> >>
> >> On 03/05/2012 04:20 PM, Malahal Naineni wrote:
> >>> Steve Dickson [steved@xxxxxxxxxx] wrote:
> >>>
> >>> Also, when you normalize, why not go the extra mile of doing it all the
> >>> way as the patch I posted? I wanted to cover specs like
> >>> "host:/server/../home/./blah". This patch only does partial
> >>> normalization. The original patch also normalizes /proc/mount entry's
> >>> pathname (this avoids dealing with trailing '/' hack that exists now).
> >> I just do not see the need for that type of complexity... Maybe I'm
> >> being a bit naive, but I see two problems here. One, v4 mounts
> >> with multiple slashes and two v4 mounts without any slashes...
> >>
> >> Now both of our patches do address those issues but mine only
> >> addresses those issues and no, it does not go the "extra mile"
> >> of addressing '..' in path names, but does it need to? Is
> >> there really an use case where people export things with ".."
> >> in the path?
> >>
> >> Sometimes going the just extra mile just brings more pain...
> >> for no reason... and believe me I'm no runner... 8-)
> >
> > Note that the NFSv4 server may have symlinks and/or referrals in the
> > mount path, in which case it is game over for this kind of approach
> > anyway: you can't 'normalise' your way to interpreting that...
> Well I guess we will cross that bridge when we get there... At
> this point I just want fixes these two bugs and move on...
>
> >
> > Is there any reason why we actually care about checking the crap
> > in /etc/mtab on umount?
> >
> Yeah... its called backwards compatibility with older distros...
> Believe, if I could bury mtab I would... in a New York minute!
> I just don't see it happening...
Yes, but despite all your work, you are just replacing one broken model
by another.
At least with the current code, they can _see_ that the model is broken
and have an immediate incentive to move to the
mtab-is-a-symlink-to-/proc/mounts based model. The latter is in any case
the only one that is valid in the mount-namespace based world in which
we've been living for the past 5 years or so...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
