On Mon, 2012-03-05 at 19:27 -0500, Steve Dickson wrote:
>
> On 03/05/2012 04:20 PM, Malahal Naineni wrote:
> > Steve Dickson [steved@xxxxxxxxxx] wrote:
> >
> > Also, when you normalize, why not go the extra mile of doing it all the
> > way as the patch I posted? I wanted to cover specs like
> > "host:/server/../home/./blah". This patch only does partial
> > normalization. The original patch also normalizes /proc/mount entry's
> > pathname (this avoids dealing with trailing '/' hack that exists now).
> I just do not see the need for that type of complexity... Maybe I'm
> being a bit naive, but I see two problems here. One, v4 mounts
> with multiple slashes and two v4 mounts without any slashes...
>
> Now both of our patches do address those issues but mine only
> addresses those issues and no, it does not go the "extra mile"
> of addressing '..' in path names, but does it need to? Is
> there really an use case where people export things with ".."
> in the path?
>
> Sometimes going the just extra mile just brings more pain...
> for no reason... and believe me I'm no runner... 8-)
Note that the NFSv4 server may have symlinks and/or referrals in the
mount path, in which case it is game over for this kind of approach
anyway: you can't 'normalise' your way to interpreting that...
Is there any reason why we actually care about checking the crap
in /etc/mtab on umount?
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
