On Wed, 2012-02-15 at 16:35 -0500, Chuck Lever wrote:
> When NFSDBG_XDR debugging is enabled, I see a lot of
>
> encode_compound: tag=
>
> on the console. This is noise if the tag is empty. Some might argue
> that it is noise even if the tag isn't empty...
>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
>
> fs/nfs/nfs4xdr.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index 606852a..2fb129d 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -889,7 +889,9 @@ static void encode_compound_hdr(struct xdr_stream *xdr,
> * but this is not required as a MUST for the server to do so. */
> hdr->replen = RPC_REPHDRSIZE + auth->au_rslack + 3 + hdr->taglen;
>
> - dprintk("encode_compound: tag=%.*s\n", (int)hdr->taglen, hdr->tag);
> + if (unlikely(hdr->taglen != 0))
> + dprintk("%s: tag=%.*s\n", __func__,
> + (int)hdr->taglen, hdr->tag);
> BUG_ON(hdr->taglen > NFS4_MAXTAGLEN);
> p = reserve_space(xdr, 4 + hdr->taglen + 8);
> p = xdr_encode_opaque(p, hdr->tag, hdr->taglen);
>
Let's just comment out the tag dprintk for now. We don't use the tag
field at all...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
