On Wed, 2012-02-15 at 16:35 -0500, Chuck Lever wrote:
> Our dprintk() debugging facility doesn't specify any verbosity level
> for it's printk() calls, but it should.
>
> The default verbosity for printk's is KERN_DEFAULT. You might argue
> that these are debugging printk's and thus the verbosity should be
> KERN_DEBUG. That would mean that to see NFS and SUNRPC debugging
> output an admin would also have to boost the syslog verbosity, which
> would be insufferably noisy.
>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
>
> include/linux/sunrpc/debug.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h
> index c2786f2..e0927c2 100644
> --- a/include/linux/sunrpc/debug.h
> +++ b/include/linux/sunrpc/debug.h
> @@ -51,7 +51,11 @@ extern unsigned int nlm_debug;
> #undef ifdebug
> #ifdef RPC_DEBUG
> # define ifdebug(fac) if (unlikely(rpc_debug & RPCDBG_##fac))
> -# define dfprintk(fac, args...) do { ifdebug(fac) printk(args); } while(0)
> +# define dfprintk(fac, args...) \
> + do { \
> + ifdebug(fac) \
> + printk(KERN_DEFAULT args); \
> + } while (0)
> # define RPC_IFDEBUG(x) x
> #else
> # define ifdebug(fac) if (0)
>
Looks good. Applied.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
