On Thu, 2012-02-16 at 12:30 -0500, Jim Rees wrote:
> Weston Andros Adamson wrote:
>
> Send the nfs implementation id in EXCHANGE_ID requests unless the module
> parameter nfs.send_implementation_id is 0.
>
> This adds a CONFIG variable for the nii_domain that defaults to "kernel.org".
>
> Signed-off-by: Weston Andros Adamson <dros@xxxxxxxxxx>
>
> @@ -271,7 +273,12 @@ static int nfs4_stat_to_errno(int);
> 1 /* flags */ + \
> 1 /* spa_how */ + \
> 0 /* SP4_NONE (for now) */ + \
> - 1 /* zero implemetation id array */)
> + 1 /* implemetation id array of size 1 */ + \
>
> implemetation -> implementation
> Might as well fix this typo while you're at it.
>
> General comment... If this is going to be configurable, I'd rather make it a
> sysctl, and be able to set the id to whatever I want at run time. But
> that's because I like to be able to break things. I suspect Trond will
> disagree.
I do. We don't make the 'uname' configurable as a sysctl. How is this
any different? Why would you want to deliberately misrepresent which NFS
client this is to the server? The implementation id is there for error
logging purposes, nothing else...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
