Re: [PATCH 1/3] NFSv4: Send implementation id with exchange_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Weston Andros Adamson wrote:

  Send the nfs implementation id in EXCHANGE_ID requests unless the module
  parameter nfs.send_implementation_id is 0.
  
  This adds a CONFIG variable for the nii_domain that defaults to "kernel.org".
  
  Signed-off-by: Weston Andros Adamson <dros@xxxxxxxxxx>

  @@ -271,7 +273,12 @@ static int nfs4_stat_to_errno(int);
   				1 /* flags */ + \
   				1 /* spa_how */ + \
   				0 /* SP4_NONE (for now) */ + \
  -				1 /* zero implemetation id array */)
  +				1 /* implemetation id array of size 1 */ + \

implemetation -> implementation
Might as well fix this typo while you're at it.

General comment... If this is going to be configurable, I'd rather make it a
sysctl, and be able to set the id to whatever I want at run time.  But
that's because I like to be able to break things.  I suspect Trond will
disagree.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux