On Fri, 2011-09-23 at 07:46 -0700, Linus Torvalds wrote: > On Fri, Sep 23, 2011 at 7:34 AM, Trond Myklebust > <Trond.Myklebust@xxxxxxxxxx> wrote: > > > > My objections are due to the other cases that I pointed out, where > > Miklos's patch introduced changes in behaviour that IMO are unnecessary > > and incorrect. > > Guys, it wasn't Mikos' patch that introduced the changes! > > What's so hard to understand here? > > That's why I'm so upset. People talk stupid sh*t about "correct > behavior" when clearly no such thing *exists*. And people talk about > Miklos changes as if they were some radical change that changed > behavior, when they were only a revert to old behavior to begin with > (at least as far as autofs is concerned)! Sorry to hear you are upset about all this. And, yes, it is me that is to blame, since I pushed David to do it. I did so because I feel strongly that the semantic change to autofs is needed based on several years of experience with reports of undesirable behavior of autofs. I thought I had put forward quite a bit of the reasoning for that, and on topic with what you've asked for in this post, at least most of the time. In its simplest form I claim, for autofs it is appropriate to automount in almost all cases where the LOOKUP_FOLLOW flag is used (these should be considered as not regression with the semantic change). For the cases where it is preferred not to automount user space should (and nowadays almost always does) use ~LOOKUP_FOLLOW type syscalls. I expected some problems from the semantic change, sure, but I expected they would come from user space. Those problems just haven't materialized so far and I'm glad of that. We haven't had any non-trivial problems reported that I know about. As I've said before the problem Miklos referred to was an inconsistency in user space which the new automount code exposed, and a change has been accepted to fix it and this was done prior to Miklos posting his patch. My point is that, since we haven't had any non-trivial problems reported due to the semantic change, in what six months or more, why change it now? Ian -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
