Hi, Boaz, > -----Original Message----- > From: linux-nfs-owner@xxxxxxxxxxxxxxx [mailto:linux-nfs-owner@xxxxxxxxxxxxxxx] > On Behalf Of Boaz Harrosh > Sent: Wednesday, September 21, 2011 6:38 PM > To: Peng, Tao > Cc: bhalevy@xxxxxxxxxx; Trond.Myklebust@xxxxxxxxxx; linux-nfs@xxxxxxxxxxxxxxx; > honey@xxxxxxxxxxxxxx; rees@xxxxxxxxx > Subject: Re: [PATCH 2/3] pnfs: introduce pnfs private workqueue > > On 09/21/2011 01:23 PM, tao.peng@xxxxxxx wrote: > > > > Unless we do following: > > 1. preallocate memory for extent state convertion > > 2. use nfsiod/rpciod to handle bl_write_cleanup > > 3. for pnfs error case, create a kthread to recollapse and resend to MDS > > > > not sure if it worth the complexity though... > > > > Cheers, > > Tao > > > > Please forgive my ignorance but what is the big difference between > a kthread and a workqueue? I thought a workqueue is just a kthread > and some memory structures (list). Sorry for being not clear... By kthread, I mean a thread that runs only once and does what we need and then exits, if I read code correctly, just like the state recovery thread that Trond mentioned above. And as Trond explained, since the error case should be rare, it is not necessary to keep a thread up and waiting for it all the time. And by workqueue, I think you know exactly what it is :) Cheers, Tao > > I agree with "keep things simple" > > But what do I know ;-) > > Thanks > Boaz > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html ��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
