On 06/09/2011 01:29 PM, Ben Greear wrote: > On 06/09/2011 10:18 AM, Steve Dickson wrote: >> Hello, >> >> >> On 06/08/2011 07:01 PM, greearb@xxxxxxxxxxxxxxx wrote: >>> From: Ben Greear<greearb@xxxxxxxxxxxxxxx> >>> >>> This lets one specify the source IP address for >>> sockets, allowing users to leverage routing rules >>> on multi-homed systems. >> Right out of the box I do think some support like >> this would be good... but I not convinced on how needed >> something like this is which means there is a lot of >> change here for basically not... But lets continue >> to talk about to see where we end up.... >> >> One thing you must do is break up this patch in to >> a more readable patch series. There is no way I going >> to commit a patch that is close to 1500 lines >> that so invasive. > > The vast majority of the patch is adding an extra > argument to various methods to get things to compile. Yeah I know... I saw that... But there has to be some logical way to break this up.. > > Do you want me to break those changes into individual > chunks, or should I just separate the parsing & documentation > chunks out? I guess that would be start.... but just breaking this up unto just a couple patches probably will not do anything for readability either... > > I can dummy stuff out with passing NULL around to make > lots of smaller patches, but I'm not sure it helps > any readability. I don't know either... but it make me very nervous to apply a 1400+ line patch especially when its basically rewriting mount... I've broken mount before... Its not a pretty sight... ;-) steved. > > Thanks, > Ben > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
