Hello, On 06/08/2011 07:01 PM, greearb@xxxxxxxxxxxxxxx wrote: > From: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > This lets one specify the source IP address for > sockets, allowing users to leverage routing rules > on multi-homed systems. Right out of the box I do think some support like this would be good... but I not convinced on how needed something like this is which means there is a lot of change here for basically not... But lets continue to talk about to see where we end up.... One thing you must do is break up this patch in to a more readable patch series. There is no way I going to commit a patch that is close to 1500 lines that so invasive. Here is how I create patch series. git pull devel-tree git checkout -b devel-branch make changes git commit -s -a make more changes git commit -s -a [Note, each one of the commits (or patches) have to be stand-alone patches ] [Which means after each commit the tree has to compile and be functional ] When all the changes are done, create the patches like: git format-patch -n -o /tmp/sumbit --cover-letter commit1^..commitN edit /tmp/summit/*cover* to explain your changes Then post the patches with git send-email command: git send-email $DRYRUN --suppress-cc=all --suppress-from --no-chain-reply-to --from "Your Name <emailaddress@xxxxxxxxxx>" --to Linux NFS Mailing list <linux-nfs@xxxxxxxxxxxxxxx>" --smtp-server smtp.foobar.com /tmp/submit/*.patch Note, I'm not sure the --smtp argument is needed... but it works.. steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html