Re: [PATCH] mountd: Fix missing varialble assignment in auth_unix_gid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/6/8 Steve Dickson <SteveD@xxxxxxxxxx>:
>
>
> On 06/01/2011 02:57 PM, Pavel Shilovsky wrote:
>> When we get into auth_unix_gid at the second time, groups_len
>> is not 0 and ngroups variable leave as 0. Then we use ngroups
>> in getgrouplist that fails in this case. This patch fixes it.
>>
>> Signed-off-by: Pavel Shilovsky <piastry@xxxxxxxxxxx>
>> ---
>>  utils/mountd/cache.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
>> index df6b38f..dbe20e9 100644
>> --- a/utils/mountd/cache.c
>> +++ b/utils/mountd/cache.c
>> @@ -138,7 +138,7 @@ static void auth_unix_gid(FILE *f)
>>       static gid_t *groups = NULL;
>>       static int groups_len = 0;
>>       gid_t *more_groups;
>> -     int ngroups = 0;
>> +     int ngroups;
>>       int rv, i;
>>       char *cp;
>>
>> @@ -147,9 +147,11 @@ static void auth_unix_gid(FILE *f)
>>               if (!groups)
>>                       return;
>>
>> -             groups_len = ngroups = INITIAL_MANAGED_GROUPS;
>> +             groups_len = INITIAL_MANAGED_GROUPS;
>>       }
>>
>> +     ngroups = groups_len;
>> +
>>       if (readline(fileno(f), &lbuf, &lbuflen) != 1)
>>               return;
>>
> Committed...
>
> steved.
>

See it, thanks!

-- 
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux