On Fri, May 20, 2011 at 03:15:33PM -0400, Trond Myklebust wrote: > On Fri, 2011-05-20 at 14:59 -0400, Dr. J. Bruce Fields wrote: > > > Bruce, > > > > > > If the clientid expired, is it possible that the server may have handed > > > out the same numerical short clientid to someone else and that explains > > > why the RENEW is succeeding? > > > > Clientid's are created from a u32 counter that's sampled only under the > > state lock, so it sounds unlikely. > > > > I think more likely would be some bug affecting the lifetime of a > > stateid--e.g. if the server destroyed a lock stateid earlier than it > > should in some case, then this would happen. (Since, as I say, we > > assume EXPIRED for any stateid we don't recognize.) > > Shouldn't that be a NFS4ERR_BAD_STATEID instead of NFS4ERR_EXPIRED? Probably so, but absent a bug on either side I can't see a case where it would make a difference; can you? --b. > The > latter should really be reserved for the case where you know that this > stateid came from an expired lease. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
