On Tue, Mar 22, 2011 at 05:44:17PM +0800, Mi Jinlong wrote: > I have made a mistake about this case, we don't need the filehandle from GETFHres, > that is just unnecessary. > > Thanks for your point about the homedir, > I found a function named use_obj at nfs4lib which can solve our problem. > > After fixed, maybe the following patch is OK now. Great, thanks--applied. At this point I've applied and pushed out everything I've taken from you. So let me know what else you still have that's not in my git repo. I know there are the reclaim_complete tests that you're still looking at, but there might also be a few other odd tests that I still had questions about? --b. > > --- > thanks, > Mi Jinlong > > >From e9faf0c2e86421012296f95ce5cd9cd3338f98a2 Mon Sep 17 00:00:00 2001 > From: Mi Jinlong <mijinlong@xxxxxxxxxxxxxx> > Date: Mon, 22 Mar 2011 19:25:23 +0800 > Subject: [PATCH] CLNT: test resues slot ID > > Signed-off-by: Mi Jinlong <mijinlong@xxxxxxxxxxxxxx> > --- > nfs4.1/server41tests/st_sequence.py | 29 +++++++++++++++++++++++++++++ > 1 files changed, 29 insertions(+), 0 deletions(-) > > diff --git a/nfs4.1/server41tests/st_sequence.py b/nfs4.1/server41tests/st_sequence.py > index c11fdc9..7277290 100644 > --- a/nfs4.1/server41tests/st_sequence.py > +++ b/nfs4.1/server41tests/st_sequence.py > @@ -363,3 +363,32 @@ def testBadSequenceidAtSlot(t, env): > > res = c.c.compound([op.sequence(sid, nfs4lib.dec_u32(seqid), 2, 3, True)]) > check(res, NFS4ERR_SEQ_MISORDERED) > + > +def testReuseSlotID(t, env): > + """ If client reuses a slot ID and sequence ID for a completely > + different request, server MAY treat the request as if it is > + a retry of what it has already executed. rfc5661 18.46.3 > + > + FLAGS: sequence all > + CODE: SEQ14 > + """ > + c = env.c1.new_client(env.testname(t)) > + # CREATE_SESSION > + sess1 = c.create_session() > + > + name = "%s_1" % env.testname(t) > + res = create_file(sess1, name) > + check(res) > + > + sid = sess1.sessionid > + seqid = nfs4lib.inc_u32(sess1.seqid) > + dir = sess1.c.homedir > + > + res = c.c.compound([op.sequence(sid, seqid, 0, 0, TRUE)] + > + nfs4lib.use_obj(dir) + [op.remove(name)]) > + check(res) > + > + # Reuses slot ID and sequence ID for different request > + res = c.c.compound([op.sequence(sid, seqid, 0, 0, TRUE)] + > + nfs4lib.use_obj(dir) + [op.rename(name, "test")]) > + check(res) > -- > 1.7.4.1 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
