On Fri, Mar 04, 2011 at 05:06:31PM +0800, Mi Jinlong wrote: > Maybe the following one is better than before. Looks good to me, thanks! Very minor nit: > +def testReuseSlotID(t, env): > + """ If client reuses a slot ID and sequence ID for a completely > + different request, server MAY treat the request as if it is > + a retry of what it has already executed. rfc5661 18.46.3 > + > + FLAGS: sequence all > + CODE: SEQ14 > + """ > + c = env.c1.new_client(env.testname(t)) > + # CREATE_SESSION > + sess1 = c.create_session() > + > + name = "%s_1" % env.testname(t) > + res = create_file(sess1, name) Could you check your patches for trailing whitespace? (There's an extra space at the end of that line.) (No need to resend anything.) --b. > + check(res) > + > + sid = sess1.sessionid > + seqid = nfs4lib.inc_u32(sess1.seqid) > + fh = res.resarray[3].object > + homedir = sess1.c.homedir[0] > + > + res = c.c.compound([op.sequence(sid, seqid, 0, 0, TRUE), op.putrootfh(), > + op.lookup(homedir), op.remove(name)]) > + check(res) > + > + # Reuses slot ID and sequence ID for different request > + res = c.c.compound([op.sequence(sid, seqid, 0, 0, TRUE), op.putrootfh(), > + op.lookup(homedir), op.rename(name, "test")]) > + check(res) > -- > 1.7.4.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
