On Feb 8, 2011, at 11:08 AM, Karel Zak wrote: > On Tue, Feb 08, 2011 at 10:43:23AM -0500, Chuck Lever wrote: >> Nice work, just a few nits so far. > > I'll send updated version later. Thanks for your feedback. > >> I'll wait for utils-linux >> 2.19... and we have NFS Connectathon (http://www.connectathon.org) >> in a couple of weeks, so it will be March before I can spend some >> quality time with this. >> >> Also, I'm cleaning up a version of parse_opt.c and token.c for you, >> if you want to include these in libmount at some point. > > The library already has some code for mount options parsing, but there > is not code to create a list from parsed mount options. The library > already uses struct list_head (originally probably from e2fsprogs > and Linux kernel, see include/list.h in util-linux), so maybe we can > use it for mount options too. "struct mount_options" is meant to be opaque to callers. Originally I expected there would be more than just a list in it. As it turned out, a doubly-linked list is all that is needed. I can experiment with replacing "struct mount_options" with "struct list_head." I rather prefer the opacity, as that discourages callers from tinkering with the option lists themselves. It's a nit, I suppose. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
