Re: [PATCH 1/2] mount: move generic functions to utils.c and network.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 08, 2011 at 10:43:23AM -0500, Chuck Lever wrote:
> Nice work, just a few nits so far.

I'll send updated version later. Thanks for your feedback.

> I'll wait for utils-linux
> 2.19... and we have NFS Connectathon (http://www.connectathon.org)
> in a couple of weeks, so it will be March before I can spend some
> quality time with this.
> 
> Also, I'm cleaning up a version of parse_opt.c and token.c for you,
> if you want to include these in libmount at some point.

The library already has some code for mount options parsing, but there
is not code to create a list from parsed mount options. The library 
already uses struct list_head (originally probably from e2fsprogs
and Linux kernel, see include/list.h in util-linux), so maybe we can
use it for mount options too.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux