Re: [nfs] nfs: Fix nfs_sockaddr_match_ipaddr6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep 3, 2010, at 12:15 PM, Ben Greear wrote:

> A typo caused this method not not actually compare the
> two addresses passed in.  It returned true in almost all
> cases instead.

>From the perspective of the local logic, that looks correct.  Have you tried this with IPv6 mounts?  Notice any overall changes in behavior?

> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> ---
> :100644 100644 4e7df2a... e734072... M	fs/nfs/client.c
> fs/nfs/client.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 4e7df2a..e734072 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -275,7 +275,7 @@ static int nfs_sockaddr_match_ipaddr6(const struct sockaddr *sa1,
> 	    sin1->sin6_scope_id != sin2->sin6_scope_id)
> 		return 0;
> 
> -	return ipv6_addr_equal(&sin1->sin6_addr, &sin1->sin6_addr);
> +	return ipv6_addr_equal(&sin1->sin6_addr, &sin2->sin6_addr);
> }
> #else	/* !defined(CONFIG_IPV6) && !defined(CONFIG_IPV6_MODULE) */
> static int nfs_sockaddr_match_ipaddr6(const struct sockaddr *sa1,
> -- 
> 1.6.2.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
chuck[dot]lever[at]oracle[dot]com




--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux