On Tue, Jul 13, 2010 at 03:50:36PM -0400, Trond Myklebust wrote: > NFS can't distinguish between a datasync and a full sync: a successful > COMMIT operation guarantees that both data+metadata updates are on disk. > For this reason we ignore the 'datasync' parameter in our fsync > implementation. That's not what the datasync parameter means. Both fsync and fdatasync will commit data and metadata to disk, the questions is how much metadata we need to commit. For fdatasync it's only the metadata requires to locate the file data on disk, an fsync requires everything (which is the above + timestamps basically). I suspect for NFS the difference still doesn't matter, I'd just try to make it clear. > Would it perhaps help if I added a comment to that effect in > nfs_file_fsync() itself? Yes, comments explaining such higher level concepts are always good. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
