On Mon, 2010-07-12 at 21:13 -0400, Christoph Hellwig wrote: > > /* Flush writes to the server and return any errors */ > > - return nfs_do_fsync(ctx, inode); > > + return vfs_fsync(file, 0); > > Either the argument to vfs_fsync or the comment needs some changes. > datasync = 0 means we don't just flush writes but also metadata. I > don't know enough about the NFS CTO guarantees to figure which one you > actually want. > NFS can't distinguish between a datasync and a full sync: a successful COMMIT operation guarantees that both data+metadata updates are on disk. For this reason we ignore the 'datasync' parameter in our fsync implementation. Would it perhaps help if I added a comment to that effect in nfs_file_fsync() itself? Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
