Re: [PATCH] make capabilities support optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/23/2010 12:29 PM, Steve Dickson wrote:
On 04/20/2010 04:46 AM, Mike Frysinger wrote:
The new code using libcap is quite minor, so rather than always reqiure
libcap support, make it a normal --enable type flag.  Current default
behavior is retained -- if libcap is found, it is enabled, else it is
disabled like every nfs-utils version in the past.

Signed-off-by: Mike Frysinger<vapier@xxxxxxxxxx>

Committed...

I somehow missed this one. Why are we disabling libcap? And why are we adding another --enable flag when everyone has agreed that we should avoid that if at all possible?

It is especially on older systems that nfs-utils will break without libcap support. Without CAP_NET_BIND, pmap_unregister() will fail when statd is shut down, leaving NSM registered with the portmapper, but with no active listeners. When statd is started up again, it won't be able to register the new NSM listener ports.

That's the bug that was fixed by the addition of libcap. I don't agree that is "quite minor."

--
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux