On Thu, Apr 22, 2010 at 10:48:31AM -0400, J. Bruce Fields wrote:
> On Thu, Apr 22, 2010 at 10:32:23AM -0400, J. Bruce Fields wrote:
> > Enforce the rules about compound op ordering.
> >
> > Motivated by implementing RECLAIM_COMPLETE, for which the client is
> > implicit in the current session, so it is important to ensure a
> > succesful SEQUENCE proceeds the RECLAIM_COMPLETE.
>
> The other problem here is that while we have a reference count on the
> session itself preventing it from going away till the compound is done,
> I don't see what prevents the associated clientid from going away.
That session reference counting also doesn't make sense to me: we should
never allow a client to disappear while a session is in use.
> > +static bool nfsd4_last_compound_op(struct svc_rqst *rqstp)
> > +{
> > + struct nfsd4_compoundres *resp = rqstp->rq_resp;
> > + struct nfsd4_compoundargs *argp = rqstp->rq_argp;
> > +
> > + return argp->opcnt == resp->opcnt;
> > +}
> > +
> > __be32
> > nfsd4_destroy_session(struct svc_rqst *r,
> > struct nfsd4_compound_state *cstate,
> > @@ -1380,6 +1388,11 @@ nfsd4_destroy_session(struct svc_rqst *r,
> > * - Do we need to clear any callback info from previous session?
> > */
> >
Also to do in destroy_session, from
http://tools.ietf.org/search/rfc5661#section-13.9 "DESTROY_SESSION MUST
be invoked on a connection that is associated with the session being
destroyed." We should probably be enforcing that here. I'm not sure
what error to return.
--b.
> > + if (!memcmp(&sessionid->sessionid, &cstate->session->se_sessionid,
> > + sizeof(struct nfs4_sessionid))) {
> > + if (!nfsd4_last_compound_op(r))
> > + return nfserr_not_only_op;
> > + }
> > dump_sessionid(__func__, &sessionid->sessionid);
> > spin_lock(&sessionid_lock);
> > ses = find_in_sessionid_hashtbl(&sessionid->sessionid);
> > --
> > 1.6.3.3
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
