Re: Possible-Patch: unregister bdi on error path.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-03-11 at 11:22 +1100, Neil Brown wrote: 
> On Wed, 10 Mar 2010 18:01:47 -0500
> Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote:
> 
> > Yes. It looks as if you have indeed found a bug.
> > 
> > My main comment is that in order to be complete the patch should also
> > address the cases of nfs_xdev_get_sb(), nfs4_remote_get_sb(),
> > nfs4_xdev_get_sb(), and nfs4_remote_referral_get_sb(). They appear to
> > suffer from the same problem...
> > 
> 
> Good point.  Patch follows.
> I have compile-tested this but nothing more.  I'm not even sure how I can
> test it as it only affect error paths that are not easy to force.

Agreed that it is faith based patching :-) but I'm willing to go with
that unless someone can show me that your argument is incorrect.

Will apply...

Cheers
  Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux