On Fri, 2010-01-29 at 16:27 -0500, Christoph Hellwig wrote: > On Fri, Jan 29, 2010 at 04:18:26PM -0500, Trond Myklebust wrote: > > nfsd: Use vfs_fsync_range() in nfsd_commit > > > > From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> > > > > The NFS COMMIT operation allows the client to specify the exact byte range > > that it wishes to sync to disk in order to optimise server performance. > > > > Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> > > Looks good to me, > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! > > * Commit all pending writes to stable storage. > > - * Strictly speaking, we could sync just the indicated file region here, > > - * but there's currently no way we can ask the VFS to do so. > > The commit above could use some addition that the commit only happens > for the specified range. I'll add in a couple of words. > And not actually touched by your patch, but that is the reason to > open/close the file if we don't actually do anything with it for an > async export? I must admit that I was wondering about that too. I'm assuming that the reason is to provide consistent behaviour w.r.t. access checks and possibly also to ensure that NFSv4 delegations are revoked. Perhaps Bruce could comment? Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
