Re: nfsd: Use vfs_fsync_range() in nfsd_commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 29, 2010 at 04:18:26PM -0500, Trond Myklebust wrote:
> nfsd: Use vfs_fsync_range() in nfsd_commit
> 
> From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> 
> The NFS COMMIT operation allows the client to specify the exact byte range
> that it wishes to sync to disk in order to optimise server performance.
> 
> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>

Looks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

>   * Commit all pending writes to stable storage.
> - * Strictly speaking, we could sync just the indicated file region here,
> - * but there's currently no way we can ask the VFS to do so.

The commit above could use some addition that the commit only happens
for the specified range.


And not actually touched by your patch, but that is the reason to
open/close the file if we don't actually do anything with it for an
async export?
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux