On Thu, 21 Nov 2024 at 00:17, Dan Shelton <dan.f.shelton@xxxxxxxxx> wrote: > > On Wed, 20 Nov 2024 at 21:56, Steve Dickson <steved@xxxxxxxxxx> wrote: > > > > > > > > On 11/19/24 11:59 AM, Steve Dickson wrote: > > > From: Seiichi Ikarashi <s.ikarashi@xxxxxxxxxxx> > > > > > > The rsize/wsize values are not multiples of 1024 but multiples of the > > > system's page size or powers of 2 if < system's page size as defined > > > in fs/nfs/internal.h:nfs_io_size(). > > > > > > Signed-off-by: Steve Dickson <steved@xxxxxxxxxx> > > Committed... (tag: nfs-utils-2-8-2-rc2) > > > > I know we are still discussing this but I think > > this version is better than what we have. > > Nope. The code is IMO wrong, and the docs are buggy too. > > > > > So update patches are welcome! > > Solaris, HPUX, FreeBSD and Windows NFSv3/v4 implementations all count in bytes. I hereby concur, this is better to be consistent across operating systems. In any case this is better than some machine- or hardware-specific config option called "default page size", which no one knows at boot time. Ced -- Cedric Blancher <cedric.blancher@xxxxxxxxx> [https://plus.google.com/u/0/+CedricBlancher/] Institute Pasteur
