On Wed, 20 Nov 2024 at 21:56, Steve Dickson <steved@xxxxxxxxxx> wrote: > > > > On 11/19/24 11:59 AM, Steve Dickson wrote: > > From: Seiichi Ikarashi <s.ikarashi@xxxxxxxxxxx> > > > > The rsize/wsize values are not multiples of 1024 but multiples of the > > system's page size or powers of 2 if < system's page size as defined > > in fs/nfs/internal.h:nfs_io_size(). > > > > Signed-off-by: Steve Dickson <steved@xxxxxxxxxx> > Committed... (tag: nfs-utils-2-8-2-rc2) > > I know we are still discussing this but I think > this version is better than what we have. Nope. The code is IMO wrong, and the docs are buggy too. > > So update patches are welcome! Solaris, HPUX, FreeBSD and Windows NFSv3/v4 implementations all count in bytes. Why does Linux again have to be the oddball of the family and count in pages? Not-invented-here-syndrome, need-reason-why-companies-have-to-pay-for-Linux-admin-training? My recommendation would be to fix the code to count in bytes, rounded to the page size, and being a minimum of one page size. Will bite of course if someone chooses 2M pages as default on x86-64. Dan -- Dan Shelton - Cluster Specialist Win/Lin/Bsd
