On Wed, 6 Jan 2010 14:58:19 -0500 "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > On Wed, Jan 06, 2010 at 02:42:47PM -0500, Jeff Layton wrote: > > On Wed, 6 Jan 2010 14:17:06 -0500 > > "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > > > > > This probably just shows I'm not reading carefully, but: are you > > > requiring root, and messing with their existing nfs configuration at > > > all? > > > > > > For the export stuff it would also be great to have some tests that set > > > up a few dummy exports (using tmpfs?) and tried to mount them (just over > > > loopback), but I'd be afraid someone would try to run "make check" on > > > their production server. So I'm not sure where to put that kind of > > > test. > > > > > > > The script I have so far doesn't check for root privs, but it won't > > work unless you have them since statd will fail to start. statd > > currently requires root privs to start though it does drop them soon > > afterward. > > > > I'm open to suggestions on changing this as I'm not crazy about that > > either. > > My feeling is that it will be hard to find a realistic way to test > everything without having root and taking over the machine to some > degree. > > Just so long as the user understands whether it needs to be run as root, > whether it's safe to be run on a host connected to the network, etc.... > I don't know if 'make check' is the right ui for that. > I guess I don't really envision this being run by people who are just downloading and building the sources. I see it as more useful for us as developers of this code as a way to periodically sanity check functionality. I can certainly add a check here to tell people "Hey you need to run make check as root, don't hurt yourself if you do". I can also do something that says "Hey you need to start up statd, mountd, etc...run these programs as root and hit return when you're done". Any way you look at it though, yes you will need to take over the machine to some degree. I'm not sure that "make check" is any worse than any other UI though. It certainly has the advantage of not requiring a lot of extra infrastructure. If we require a lot of extra infrastructure to run a test suite then I fear that no one will ever bother run it. I think convenience is a requirement here. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
