> On Sep 7, 2024, at 3:08 PM, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > > On Sat, Sep 07, 2024 at 04:09:33PM +0000, Chuck Lever III wrote: >> >>> On Sep 7, 2024, at 11:17 AM, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: >>> >>> Rather than have general concern for LOCALIO doing something wrong, >>> we'd do well to make sure there is proper test coverage for required >>> shutdown sequences (completely indepent of LOCALIO, maybe that already >>> exists?). >> >> That is on the to-do list for the NFSD kdevops CI infrastructure, >> but unfortunately implementation has not been started yet. > > Could be a good project for me to help with. I'm on the fence between > kdevops and ktest, ideally I could come up with something that'd > easily hook into both test harnesses. > > Supporting both would be simple if the new tests were added to a > popular testsuite that both can run (e.g. xfstests, or any other > separate nfs/nfsd testsuite you may have?). Or is "NFSD kdevops CI" > itself what your tests be engineered with? kdevops is a CI framework; the individual tests are "workflows" that run under that framework. Source: https://github.com/linux-kdevops/kdevops Right now kdevops can run these tests (created elsewhere): - (x)fstests - the git regression suite - ltp - nfstests (from Jorge Borge) - pynfs ... in addition to the kernel self-tests, CXL-related tests, and a system reboot test, among others. We will have to develop something from scratch that is geared specifically towards NFSD on Linux. Probably the closest fit for unit-testing administrative commands on Linux is ltp: Source: https://github.com/linux-test-project/ltp Docs: https://linux-test-project.readthedocs.io/en/latest/ If ktest can run ltp, then new ltp tests could be inserted easily into both kdevops or ktest. Or the NFSD administrative tests might be added to the kernel's self-test suite or to Kunit; such tests would reside under tools/ in the kernel source tree. A third alternative would be to add the tests to the nfs-utils package, where Linux NFS user space tooling lives today; but I don't think there's a lot of test framework in that package right now. -- Chuck Lever
