On Tue, 30 Jul 2024, Chuck Lever wrote: > > In 2/2, what is the reason to make svc_thread_init_status() a static > inline rather than an exported function? I don't think this is going > to be a performance hot path, but maybe it becomes one in a future > patch? > Sorry - I missed this question the first time. My reasoning was that it was a tiny function which would be optimised even smaller in two out of three call sites where the err number is a constant zero. Also my original draft didn't even have this as a function but was open coded. I don't think it matters much either way. Thanks, NeilBrown