On Mon, Jul 29, 2024 at 12:18:19PM +1000, NeilBrown wrote: > These two patches replace my previous patch: > [PATCH 07/14] Change unshare_fs_struct() to never fail. > > I had explored ways to change kthread_create() to avoid the need for > GFP_NOFAIL and concluded that we can do everything we need in the sunrpc > layer. So the first patch here is a simple cleanup, and the second adds > simple infrastructure for an svc thread to confirm that it has started > up and to report if it was successful in that. > > Thanks, > NeilBrown > > > > [PATCH 1/2] sunrpc: merge svc_rqst_alloc() into svc_prepare_thread() > [PATCH 2/2] sunrpc: allow svc threads to fail initialisation cleanly This series does not apply to nfsd-next. It looks like 1/2 expects to see the EXPORT_SYMBOL after svc_rqst_alloc() that you already removed in "SUNRPC: make various functions static, or not exported." Also, 1/2 is From: your brown.name account, but the SoB is your SuSE email. (Maybe that doesn't matter). Can you rebase and resend? In 2/2, what is the reason to make svc_thread_init_status() a static inline rather than an exported function? I don't think this is going to be a performance hot path, but maybe it becomes one in a future patch? -- Chuck Lever
