Re: BUG in nfs_read_folio() when tracing is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 05, 2024 at 01:45:11PM +0000, Chuck Lever III wrote:
> So Dave, I haven't tested the patch you posted a couple
> days ago, because there hasn't been a clear answer about
> whether nfs_read_folio() needs to protect itself against
> the ->mapping changing, in which case, that's probably
> a better fix.

->read_folio is called with the folio locked and only unlocks it
on I/O completion, so it doesn't really need any protection.  So the
patch to simply move the trace point to before unlocking the folio
should fix the issue.

Alternatively we could just use the mapping from the inode variable
and pass it in.





[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux