On Nov 24, 2009, at 9:17 AM, Steve Dickson wrote:
On 11/23/2009 05:00 PM, Chuck Lever wrote:
Steve -
As requested, here are the two patches that convert statd and
sm-notify to use the nfs-utils' xlog() facility, replacing local
variants.
---
Committed and thanks for breaking them up!
Question, How did you differentiate between D_CALL and D_GENERAL?
I'm thinking about rolling both those types into a new xlog_debug()
function... since that what those types seem to be...
These are existing enum values. See support/include/xlog.h. D_CALL
is generally used for function tracing, more or less, and D_GENERAL is
used as a grab bag.
The debug level is set via xlog_config() or xlog_sconfig(). It looks
like mountd uses the whole range of values, and you can set them on
the command line. It would be nice if statd allowed that too.
You don't need to change or eliminate any of the values. A putative
xlog_debug() function might look like this:
void
xlog_debug(const char* fmt, ...)
{
va_list args;
va_start(args, fmt);
xlog_backend(D_GENERAL, fmt, args);
va_end(args);
}
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
