Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
From: Chuck Lever III <chuck.lever@xxxxxxxxxx>
Date: Fri, 15 Dec 2023 19:35:57 +0000
Accept-language: en-US
Cc: Neil Brown <neilb@xxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Linux NFS Mailing List <linux-nfs@xxxxxxxxxxxxxxx>
In-reply-to: <ac74bdb82e114d71b26864fe51f6433b@AcuMS.aculab.com>
References: <20231208033006.5546-1-neilb@suse.de> <20231208033006.5546-2-neilb@suse.de> <ZXMv4psmTWw4mlCd@tissot.1015granger.net> <170224845504.12910.16483736613606611138@noble.neil.brown.name> <20231211191117.GD1674809@ZenIV> <170233343177.12910.2316815312951521227@noble.neil.brown.name> <20231211231330.GE1674809@ZenIV> <20231211232135.GF1674809@ZenIV> <170242728484.12910.12134295135043081177@noble.neil.brown.name> <ac74bdb82e114d71b26864fe51f6433b@AcuMS.aculab.com>

> On Dec 15, 2023, at 1:27 PM, David Laight <David.Laight@xxxxxxxxxx> wrote:
> 
> ...
> 
> I'm also sure I remember that nfs wasn't supposed to respond to a write
> until it had issued the actual disk write - but maybe no one do that
> any more because it really is too slow.
> (Especially if the 'disk' is a USB stick.)

That rule applies only to NFSv2, which no-one should use any more.

NFSv3 and later use a two-phase write. Clients send a COMMIT after
an UNSTABLE WRITE to get the persistence guarantee.

--
Chuck Lever

References:
- [PATCH 0/3] nfsd: fully close all files in the nfsd threads
  - From: NeilBrown
- [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: NeilBrown
- Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: Chuck Lever
- Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: NeilBrown
- Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: Al Viro
- Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: NeilBrown
- Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: Al Viro
- Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: Al Viro
- Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: NeilBrown
- RE: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
  - From: David Laight

Prev by Date: [PATCH 3/3] NFSD: Fix server reboot hang problem when callback workqueue is stuck
Next by Date: Re: [PATCH 1/3] SUNRPC: remove printk when back channel request not found
Previous by thread: RE: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
Next by thread: RE: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux USB Development] [Linux Media Development] [Video for Linux] [Linux NILFS] [Linux Audio Users] [Yosemite Info] [Linux SCSI]