On 12/7/23 9:44 AM, Chuck Lever wrote:
On Wed, Dec 06, 2023 at 04:33:32PM -0500, Olga Kornievskaia wrote:From: Olga Kornievskaia <kolga@xxxxxxxxxx> If we have rpc_gss_sccreate in tirpc library define HAVE_TIRPC_GSS_SECCREATE, which would allow us to handle bad_integrity errors. Signed-off-by: Olga Kornievskaia <kolga@xxxxxxxxxx> --- aclocal/libtirpc.m4 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/aclocal/libtirpc.m4 b/aclocal/libtirpc.m4 index bddae022..ef48a2ae 100644 --- a/aclocal/libtirpc.m4 +++ b/aclocal/libtirpc.m4 @@ -26,6 +26,11 @@ AC_DEFUN([AC_LIBTIRPC], [ [Define to 1 if your tirpc library provides libtirpc_set_debug])],, [${LIBS}])])+ AS_IF([test -n "${LIBTIRPC}"],+ [AC_CHECK_LIB([tirpc], [rpc_gss_seccreate], + [AC_DEFINE([HAVE_TIRPC_GSS_SECCREATE], [1], + [Define to 1 if your tirpc library provides rpc_gss_seccreate])],, + [${LIBS}])]) AC_SUBST([AM_CPPFLAGS]) AC_SUBST(LIBTIRPC)It would be better for distributors if this checked that the local version of libtirpc has the rpc_gss_seccreate fix that you sent. The PKG_CHECK_MODULES macro should work for that, once you know the version number of libtirpc that will have that fix.
This is some the distro need to worried about... Not upstream. Yes... do to the recent changes to libtirpc, I did need to add a requirement to nfs-utils (in Fedora) so it would compile.
Also, this patch should come either before "gssd: switch to using rpc_gss_seccreate()" or this change should be squashed into that patch, IMO.Taking a quick look... The patches seem fine... but I will
take a closer look over the weekend. steved
