On Nov 10, 2009, at 6:29 PM, Andrew Morton wrote: > > > >Please don't submit patches via bugzilla. > > > >Please prepare this patch as per Documentation/SubmittingPatches and > >email it to all the recipients of this email, thanks. Ok, I will do so. On Tue, Nov 10, 2009 at 06:38:05PM -0500, Chuck Lever wrote: > Why wouldn't you bump the size of the buffer by two as well? > Otherwise valid universal addresses that are RPCBIND_MAXUADDRLEN > bytes long will fail here. > > > memcpy(buf, uaddr, uaddr_len); There is no need to increase the size of the buffer since the new check (if (uaddr_len > sizeof(buf) - 2)) will terminate the function in case the valid universal address is RPCBIND_MAXUADDRLEN bytes. Cheers, Patroklos -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
