On Mon, 2009-09-14 at 16:04 -0400, J. Bruce Fields wrote: > On Mon, Sep 14, 2009 at 08:23:37PM +0300, Benny Halevy wrote: > > Where exactly is the NULL deref? > > > > > > > > Note--that's fixed 7 patches later in fsd41: Refactor create_client(), > > > but I don't actually understand how yet. > > > > unconf's cl_flavor initialization was moved in the latter patch > > from nfsd4_setclientid to create_client so maybe this could > > be the culprit (though, assuming it is initialized to 0 > > it will choosing implicitly authnull_ops in rpcauth_create() > > which _should_ work...) > > Oog, yes, turns out auth_null doesn't initialize the cred hashtable. So > also reproduceable by mounting with "mount -tnfs4 -osec=null", then > touching a file. So either we should be using some other interface, or > rpcauth_lookupcred should be checking au_credcache, or something. There shouldn't be a need for an auth_null hashtable. It isn't a credential... Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
