On Mon, Sep 14, 2009 at 2:51 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > On Fri, Sep 11, 2009 at 06:52:54PM -0400, andros@xxxxxxxxxx wrote: >> From: Andy Adamson <andros@xxxxxxxxxx> >> >> The reply RPC header is 12 bytes, the NULL verifier is 8 bytes giving 20 >> not 24 bytes in the NFSD_MIN_HDR_SEQ_SZ calculation, > > No, 24 is right. Maybe you forgot the accept stat at the end?: yes - missed the accept state. -->Andy > > xid > msg type > reply stat > verf flavor > verf length > accept stat > > --b. > >> >> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx> >> --- >> fs/nfsd/nfs4state.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c >> index 46e9ac5..5ecb42c 100644 >> --- a/fs/nfsd/nfs4state.c >> +++ b/fs/nfsd/nfs4state.c >> @@ -420,12 +420,12 @@ gen_sessionid(struct nfsd4_session *ses) >> * each time. Therefore we can advertise a ca_maxresponssize_cached >> * value that is the number of bytes in our cache plus a few additional >> * bytes. In order to stay on the safe side, and not promise more than >> - * we can cache, those additional bytes must be the minimum possible: 24 >> + * we can cache, those additional bytes must be the minimum possible: 20 >> * bytes of rpc header (xid through accept state, with AUTH_NULL >> * verifier), 12 for the compound header (with zero-length tag), and 44 >> * for the SEQUENCE op response: >> */ >> -#define NFSD_MIN_HDR_SEQ_SZ (24 + 12 + 44) >> +#define NFSD_MIN_HDR_SEQ_SZ (20 + 12 + 44) >> >> /* >> * Give the client the number of ca_maxresponsesize_cached slots it >> -- >> 1.6.2.5 >> > _______________________________________________ > pNFS mailing list > pNFS@xxxxxxxxxxxxx > http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
