On Thu, 2009-08-20 at 18:53 -0400, J. Bruce Fields wrote:
> On Thu, Aug 20, 2009 at 06:51:28PM -0400, Trond Myklebust wrote:
> Yes, everything's built in. (Also, confirmed with just the latest
> nfs-for-2.6.32.)
>
> > If so, does it also happen when NFS (but not necessarily SUNRPC) is a
> > module?
>
> Haven't tried that yet, I can look tomorrow.
>
> > I'm wondering if the problem is that we need to ensure ordering of
> > init functions here...
Please try seeing if the following patch helps...
Cheers
Trond
--------------------------------------------------------------------
From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
SUNRPC: Ensure that sunrpc gets initialised before nfs, lockd, etc...
We can oops if rpc_pipefs isn't properly initialised before we start to set
up objects that depend upon it.
Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
---
net/sunrpc/sunrpc_syms.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
index adaa819..8cce921 100644
--- a/net/sunrpc/sunrpc_syms.c
+++ b/net/sunrpc/sunrpc_syms.c
@@ -69,5 +69,5 @@ cleanup_sunrpc(void)
rcu_barrier(); /* Wait for completion of call_rcu()'s */
}
MODULE_LICENSE("GPL");
-module_init(init_sunrpc);
+fs_initcall(init_sunrpc); /* Ensure we're initialised before nfs */
module_exit(cleanup_sunrpc);
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
