On Wed, Apr 22, 2009 at 02:06:41PM -0400, J. Bruce Fields wrote: > On Tue, Apr 21, 2009 at 09:43:41PM +0000, Al Viro wrote: > > > > AFAICS, we have a subtle bug there: if we have crossed mountpoint > > *and* it got mount --move'd away, we'll be holding only one > > reference to fs containing dentry - exp->ex_path.mnt. IOW, we > > ought to dput() before exp_put(). > > OK. So a dentry of its own doesn't hold any reference on its > filesystem? Nope. That's why you want vfsmount or superblock reference. And export *does* contain vfsmount reference, so everything's fine, provided that you drop them in the right order. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html