On Sat, 2009-02-21 at 08:06 +1100, Neil Brown wrote: > On Friday February 20, trond.myklebust@xxxxxxxxxx wrote: > > On Sat, 2009-02-21 at 06:52 +1100, Neil Brown wrote: > > > On Friday February 20, trond.myklebust@xxxxxxxxxx wrote: > > > > It should work fine. The ctime tracks the mtime in all cases except when > > > > you setacl, setfattr, chown, chgrp, chmod, or touch the directory. Those > > > > should be very rare operations for pretty much any workload... > > > > > > > > > > Does that mean you'll take the patch ?? > > > > Not as it stands. You really want to be calling > > nfs_force_lookup_revalidate() instead of invalidating the directory > > contents. > > Surely it is 'aswell' rather than 'instead' ?? > I need > invalid |= NFS_INO_INVALID_DATA; > to flush the readdir cache, and > nfs_force_lookup_revalidate(inode) > to flush the lookup cache > ?? You're right. Sorry... Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html