On Thu, 2009-02-12 at 17:11 -0500, Chuck Lever wrote: > On Feb 12, 2009, at 5:02 PM, Trond Myklebust wrote: > > On Thu, 2009-02-12 at 15:43 -0500, Chuck Lever wrote: > >> The reason we might care in this case is nlm_cmp_addr() is executed > >> more frequently than nfs_sockaddr_match_ipaddr(). > > > > Actually, I'm not sure this assertion is correct. The only users of > > nlm_cmp_addr() are nlmclnt_grant(), nlm_lookup_host() and > > nlmsvc_unlock_all_by_ip(). > > > > AFAICS, the only one that needs to be v4 mapped should be > > nlmclnt_grant, > > which is not in a performance critical path... > > So then your proposal is to ensure the two arguments of the > nlm_cmp_addr() callsite in nlmclnt_grant() are both AF_INET6? Yup... I can't see that the other two callsites need anything like that. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
