On Thu, 2008-10-23 at 23:57 -0700, Michel Lespinasse wrote: > On Thu, Oct 23, 2008 at 07:17:59PM -0400, Trond Myklebust wrote: > > > (I'm still concerned about the 3 second delay here...) > > Does this patch fix that delay? > > > > SUNRPC: Fix the setting of xprt->reestablish_timeout when reconnecting > > I applied this on top of the previous patch and it worked - but now I'm > not sure if you wanted to test this as an independant patch ??? It was meant to be applied incrementally on top of the other. > I'm wondering how the code in xs_tcp_state_change() that sets > reestablish_timeout back to XS_TCP_INIT_REEST_TO managed to not cause trouble. > > > Can I propose a patch too ? mine looks quite similar to your second patch, > but with the reestablish_timeout logic hopefully simplified... > This would cause a different regression. The current code is there in order to ensure that we apply that exponential backoff if and only if the _server_ closes the TCP connection since that would usually indicate that it is trying to deal with a resource congestion issue. We don't need to back off if we were the ones closing the socket. The issue of UDP exponential backoff is moot: the UDP code doesn't use xs_connect() at all. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
