On Thu, Sep 25, 2008 at 04:08:58PM -0400, Trond Myklebust wrote: > On Thu, 2008-09-25 at 22:30 +0300, Benny Halevy wrote: > > One more thing that seems to need fixing is rpc_bind_new_program > > which now uses the passed-in program->cl_stats but doesn't point > > to the passed-in program, but rather it only extracts its > > name, number, and stats. > > Since program->stats may possibly go away with the program > > in the refcounted world I think we should get a reference on the > > program here too. > > > > That observed, it may also be a good idea to get rid of clnt->cl_stats > > altogether and use clnt->program->stats instead to prevent any > > discrepancy. > > No. cl_stats are _per_client_ stats. program->stats are per protocol. > You can't just substitute one for the other. A "git grep cl_stats" only finds me two places where it's assigned to, both of the form clnt->cl_stats = program->stats; So it looks per-program; am I missing something? --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
