On Wed, 2008-09-24 at 13:21 -0400, J. Bruce Fields wrote: > > Well the current implementation is certainly broken. Look at what > > happens if I clone the rpc_clnt... > > Hence the comment that "we assume this rpc_client is the last user of > the program." I believe that assumption is correct in the case of nfsd > callbacks, so Benny's patch is at least not broken--just a little > ad-hoc. > > So the question is whether the above solution, which addresses only this > particular case, is sufficient, or whether we'd like something more > general, like adding a reference count to the program along with a > free_program callback called only on the final put. It's broken... Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html