On Wed, 2008-07-16 at 11:21 +0300, Benny Halevy wrote: > On Jul. 16, 2008, 0:57 +0300, Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote: > > IOW: something like > > > > > > @@static int decode_compound_hdr( > > p += XDR_QUADLEN(hdr->taglen); > > READ32(hdr->nops); > > + if (hdr->nops < 1) > > + return nfs4_stat_to_errno(hdr->status); > > return 0; > > } > > > > This certainly provides a shortcut for the nops==0 case. > However, it doesn't solve the OP_ILLEGAL case all other > cases where xdr_inline_decode failed or opnum != expected, > we can easily handle the OP_ILLEGAL case explicitly in > decode_op_hdr. Are you ok with the approach of > carrying the hdr.status in xdr->status for decode_op_hdr > use, or do you rather prefer to leave things as they are > for the invalid cases and explicitly handle only the > nops==0 and OP_ILLEGAL cases? Why do we need to handle OP_ILLEGAL in the first place? This is the client; it isn't supposed to send illegal operations... Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
