[PATCH 0/2] nfsv4 compound status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Two patches in this patchset implement what we discussed last month:
http://linux-nfs.org/pipermail/nfsv4/2008-February/007945.html

[PATCH 1/2] nfs: return negative error value from nfs{,4}_stat_to_errno

    All use sites for nfs{,4}_stat_to_errno negate their return value.
    It's more efficient to return a negative error from the stat_to_errno convertors
    rather than negating its return value everywhere. This also produces slightly
    smaller code.

[PATCH 2/2] nfs: use compound hdr.status to override op status.

    The compound header status must be equivalent to the
    status of the last operation in the compound results.
    In certain cases like lack of resources or xdr decoding error,
    the nfs server may return a non-zero status in the compound header
    which is not returned by any operation.  In this case we would
    notice that today when looking for the respective operations
    code in the results and we return -EIO when we cannot find it.
    This patch fixes that by returning the status available in the
    comound header instead.

    This patch also fixes 3 call sites where we looked at the comound
    hdr.status in the success case which is useless (yet benign).
    These are nfs4_xdr_dec_{fsinfo,setclientid,setclientid_confirm}

Benny
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux