Re: [PATCH 2/4] knfsd: remove special handling for SIGHUP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Layton wrote:
> The special handling for SIGHUP in knfsd is a holdover from much
> earlier versions of Linux where reloading the export table was
> more expensive. That facility is not really needed anymore and
> to my knowledge, is seldom-used.
>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
>   
Acked-by: Greg Banks <gnb@xxxxxxxxxxxxxxxxx>
> @@ -234,10 +226,9 @@ int nfsd_create_serv(void)
>  	}
>  
>  	atomic_set(&nfsd_busy, 0);
> -	nfsd_serv = svc_create_pooled(&nfsd_program,
> -				      nfsd_max_blksize,
> -				      nfsd_last_thread,
> -				      nfsd, SIG_NOCLEAN, THIS_MODULE);
> +	nfsd_serv = svc_create_pooled(&nfsd_program, nfsd_max_blksize,
> +				      nfsd_last_thread, nfsd, SIGINT,
> +				      THIS_MODULE);
>   
Now that there's no special interpretation of signals, you could
probably also remove the `sig' argument to svc_create_pooled() and the
svc_serv->sv_kill_signal field.

-- 
Greg Banks, P.Engineer, SGI Australian Software Group.
The cake is *not* a lie.
I don't speak for SGI.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux