[PATCH 0/4] Convert knfsd to kthread API and fix startup/shutdown races (try #2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patchset is the second attempt to change nfsd to the kthread
API. The main changes from the first patchset are:

- it includes the patch by Neil Brown to take the BKL out of nfsd
  startup/shutdown codepath. This should hopefully plug the main
  race condition that could lead to oopses when nfsd was signaled
  and then rapidly restarted before all of the existing nfsd's had
  gone down. I've also added some comments to this patch to try
  and clarify the locking for future work.

- It preserves signaling as the main method for taking down nfsd.
  While kthread_stop is easier to deal with and less racy than
  signals, a lot of distros do the equivalent of "pkill nfsd" to
  take nfsd down. Changing that would be painful. Also, using
  kthread_stop is slower than using signals, since taking down
  each thread would be serialized.

- it removes the special handling where if the last thread caught a
  SIGHUP, the kernel would leave the export cache intact

I've tested this by running I/O against the server w/ iozone while
restarting nfs service in a loop. Everything seems to work as expected.

As always, comments and suggestions are appreciated...

Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux