On Mon, 2008-05-05 at 11:55 -0400, Chuck Lever wrote: > nfs_update_inode() is the only other place that actually uses the > value of nfsi->attrtimeo (and it uses it with time_in_range). I'm > merely asking if we have verified that the behavior is correct if > nfsi- > >attrtimeo == 0. > > The logic there is abstruse, so it's difficult to tell if the (nfsi- > >attrtimeo == 0) case is behaving as expected. I don't see any > obvious problem with it right now. That part of the code is irrelevant as far as actimeo=0/noac is concerned. It is the mechanism that decides whether or not to double the existing value of nfsi->attrtimeo for the case where the file/directory hasn't changed in a while. Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html